[SPARK-29569][BUILD][DOCS] Copy and paste minified jquery instead when post-processing badges in JavaDoc#26228
Closed
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-29569][BUILD][DOCS] Copy and paste minified jquery instead when post-processing badges in JavaDoc#26228HyukjinKwon wants to merge 1 commit intoapache:masterfrom
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
jiangxb1987
approved these changes
Oct 23, 2019
Contributor
jiangxb1987
left a comment
There was a problem hiding this comment.
LGTM, pending jenkins
|
Test build #112542 has finished for PR 26228 at commit
|
srowen
approved these changes
Oct 23, 2019
Contributor
|
Thanks, merging to master! |
Member
Author
|
Thanks all! |
Member
|
Thank you all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes our documentation build to copy minified jquery file instead.
The original file
jquery.jsseems missing as of Scala 2.12 upgrade. Scala 2.12 seems started to use minifiedjquery.min.jsinstead.Since we dropped Scala 2.11, we won't have to take care about legacy
jquery.jsanymore.Note that, there seem multiple weird stuff in the current ScalaDoc (e.g., some pages are weird, it starts from
scala.collection.*or some pages are missing, or some docs are truncated, some badges look missing). It needs a separate double check and investigation.This PR targets to make the documentation generation pass in order to unblock Spark 3.0 preview.
Why are the changes needed?
To fix and make our official documentation build able to run.
Does this PR introduce any user-facing change?
It will enable to build the documentation in our official way.
Before:
After:
How was this patch tested?
Manually tested via: